Don't include objc_library generated module maps in packaged frameworks #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyfelton
reviewed
Jan 5, 2021
| @@ -172,6 +172,10 @@ def _apple_framework_packaging_impl(ctx): | |||
|
|
|||
| # collect modulemaps | |||
| for modulemap in dep[apple_common.Objc].direct_module_maps: | |||
| if modulemap.owner == dep.label: | |||
There was a problem hiding this comment.
to make sure I understand this correctly, for direct module maps of a given obj-c dependency, if the module map is generated by the dep itself, including it will cause redefinition error, so skip them at this point is the way to fix this error
|
Could we expand the test setup to cover more complex situations i.e. Unit Tests with bridging headers that import headers from the tested target? I have made the changes in this commit 1bd0996 |
thiagohmcruz
approved these changes
Jan 5, 2021
congt
approved these changes
Jan 5, 2021
|
Actually I can break this when using a bridging header with unit tests, see changes here #181 |
segiddins
force-pushed
the
segiddins/no-generated-objc-library-module-maps
branch
from
6913263 to
9f3fa62
Compare
amberdixon
approved these changes
Jan 5, 2021
|
Looping back, my import style in my bridging header was breaking this. It would be great if we could also merge in the test updates here #181 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #179, by no longer leaking an incorrect module map